Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't tolerate unready endpoints in cockroachdb example #33780

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Don't tolerate unready endpoints in cockroachdb example #33780

merged 1 commit into from
Oct 7, 2016

Conversation

a-robinson
Copy link
Contributor

@a-robinson a-robinson commented Sep 29, 2016 •
edited by k8s-oncall

That annotation was only included in the initial config due to cargo-culting, and
has the potential to break node startup if it resolves its own address
to gossip to.

@bprashanth @tschottdorf

This change is Reviewable

@a-robinson
Don't tolerate unready endpoints in cockroachdb example
b9f0b04 
That was only included in the initial config due to cargo-culting, and
has the potential to break node startup if it resolves its own address
to gossip to.
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 29, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit b9f0b04. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@spxtr
Copy link
Contributor

spxtr commented Sep 29, 2016

@k8s-bot test this kubernetes/test-infra#709

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit b9f0b04. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bgrant0607 bgrant0607 assigned bprashanth and unassigned bgrant0607 Sep 30, 2016
@bprashanth bprashanth added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 30, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit b9f0b04. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot mentioned this pull request Sep 30, 2016
Closed
@a-robinson
Copy link
Contributor Author

@k8s-bot gce e2e test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0b6040c into kubernetes:master Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bprashanth bprashanth

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@a-robinson @k8s-ci-robot @spxtr @k8s-github-robot @googlebot @bgrant0607 @bprashanth